Repository navigation
Preserve download destination until decryption and decompression succeed - #56
Open
CooperBigFoot wants to merge 1 commit into
Open
CooperBigFoot wants to merge 1 commit into
CooperBigFoot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileTransfer.fetchFilecurrently opens the destination before decoding the downloaded content. A decryption or decompression failure can therefore erase an existing file or leave a new empty file.Validation: Java 17,
./mvnw -Dtest=FileTransferTest testand./mvnw verify. Three regression tests fail on the original code; all four pass with the fix.This adds one in-memory payload buffer. It does not make filesystem writes atomic or protect against disk-write failures. Destination write failures now propagate as the already-declared
IOException, rather than being wrapped byJoinerinEbicsException.Prepared with AI assistance, with human review before publication. I have six months of top-tier Google model access for research and am investing that opportunity in verified open-source contributions. Related to #54.